Skip to content

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Jul 11, 2025

  • If all the vhashes are in the same sidecar, then it will load the same blob tx many times. This PR aims to upgrade this.

@mask-pp mask-pp requested a review from rjl493456442 as a code owner July 11, 2025 06:00
@mask-pp mask-pp changed the title eth/catalyst: Upgrade getBlobs method eth/catalyst: avoid load the same blob tx multi times Jul 14, 2025
@rjl493456442
Copy link
Member

I think it really depends on how consensus client utilize this API. Let us confirm with them first.

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's a very useful optimization.

@rjl493456442 rjl493456442 added this to the 1.16.3 milestone Aug 5, 2025
@rjl493456442 rjl493456442 merged commit e9dca3b into ethereum:master Aug 5, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants